Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Animation] Update & reword "How to play or edit animations" to be a bit more specific #137

Merged
merged 4 commits into from
Oct 6, 2024
Merged

[Animation] Update & reword "How to play or edit animations" to be a bit more specific #137

merged 4 commits into from
Oct 6, 2024

Conversation

the-overdriven
Copy link

@the-overdriven the-overdriven commented Oct 4, 2024 •
edited
Loading

I’d like to suggest some rewording in the Standalone animation doc to enhance clarity and accuracy:

  • reword "How to play or edit animations" note to be a bit more specific and visible (avoid "it" and "this" words)
  • update tool name (in latest KrxImpExp it's "Shoun's ASCII Model importer", not Kerrax)

@Shoun2137
Copy link

Shoun2137 commented Oct 4, 2024 •
edited
Loading

There's only one module that's written by me from scratch, it should be neutral like imo zengin's ASCII Model Importer

@the-overdriven
Copy link
Author

I mean the name that's in Blender under File -> Import:
image
I don't have a preference for who is listed as the author, but the docs should consistently use the same name to make it easier to find and to avoid confusion.

@Shoun2137
Copy link

ah, this shit, that explains it lol

@kamilkrzyskow
Copy link
Collaborator

@the-overdriven
Also worth noting this page will be moved later on to the blog structure ✌️
So perhaps it will be further improved during that process🤔

@kamilkrzyskow
Copy link
Collaborator

LGTM 👍 The PR is a fixup, so I don't think there is a need for other reviews.

@kamilkrzyskow kamilkrzyskow merged commit 8f7a2d8 into Gothic-Modding-Community:dev Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilkrzyskow kamilkrzyskow kamilkrzyskow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-overdriven @Shoun2137 @kamilkrzyskow